[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4f0cb67c-7f68-580a-9fbe-43b02d74c8a0@gmail.com>
Date: Tue, 23 Mar 2021 23:56:45 +0900
From: Chanwoo Choi <cwchoi00@...il.com>
To: Dong Aisheng <aisheng.dong@....com>, linux-pm@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Cc: dongas86@...il.com, kernel@...gutronix.de, shawnguo@...nel.org,
linux-imx@....com, linux-kernel@...r.kernel.org,
myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
cw00.choi@...sung.com, abel.vesa@....com
Subject: Re: [PATCH V2 RESEND 4/4] PM / devfreq: imx8m-ddrc: remove
imx8m_ddrc_get_dev_status
On 21. 3. 23. 오후 4:20, Dong Aisheng wrote:
> Current driver actually does not support simple ondemand governor
> as it's unable to provide device load information. So removing
> the unnecessary callback to avoid confusing.
> Right now the driver is using userspace governor by default.
>
> polling_ms was also dropped as it's not needed for non-ondemand
> governor.
>
> Signed-off-by: Dong Aisheng <aisheng.dong@....com>
> ---
> drivers/devfreq/imx8m-ddrc.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
> index bc82d3653bff..ecb9375aa877 100644
> --- a/drivers/devfreq/imx8m-ddrc.c
> +++ b/drivers/devfreq/imx8m-ddrc.c
> @@ -280,18 +280,6 @@ static int imx8m_ddrc_get_cur_freq(struct device *dev, unsigned long *freq)
> return 0;
> }
>
> -static int imx8m_ddrc_get_dev_status(struct device *dev,
> - struct devfreq_dev_status *stat)
> -{
> - struct imx8m_ddrc *priv = dev_get_drvdata(dev);
> -
> - stat->busy_time = 0;
> - stat->total_time = 0;
> - stat->current_frequency = clk_get_rate(priv->dram_core);
> -
> - return 0;
> -}
> -
> static int imx8m_ddrc_init_freq_info(struct device *dev)
> {
> struct imx8m_ddrc *priv = dev_get_drvdata(dev);
> @@ -429,9 +417,7 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
> if (ret < 0)
> goto err;
>
> - priv->profile.polling_ms = 1000;
> priv->profile.target = imx8m_ddrc_target;
> - priv->profile.get_dev_status = imx8m_ddrc_get_dev_status;
> priv->profile.exit = imx8m_ddrc_exit;
> priv->profile.get_cur_freq = imx8m_ddrc_get_cur_freq;
> priv->profile.initial_freq = clk_get_rate(priv->dram_core);
>
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
Powered by blists - more mailing lists