linux-kernel - Re: [PATCH v3 5/8] platform/x86: gpd pocket fan: Clean-up by using managed work init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3109f58a-91e4-09bd-d953-f43a4242c194@redhat.com>
Date:   Tue, 23 Mar 2021 16:30:38 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Matti Vaittinen <mazziesaccount@...il.com>
Cc:     Mark Gross <mgross@...ux.intel.com>, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v3 5/8] platform/x86: gpd pocket fan: Clean-up by using
 managed work init

HI,

On 3/23/21 2:57 PM, Matti Vaittinen wrote:
> Few drivers implement remove call-back only for ensuring a delayed
> work gets cancelled prior driver removal. Clean-up these by switching
> to use devm_delayed_work_autocancel() instead.
> 
> This change is compile-tested only. All testing is appreciated.
> 
> Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
> Changelog from RFCv2:
>  - RFC dropped. No functional changes.
> 
>  drivers/platform/x86/gpd-pocket-fan.c | 17 ++++++-----------
>  1 file changed, 6 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/platform/x86/gpd-pocket-fan.c b/drivers/platform/x86/gpd-pocket-fan.c
> index 5b516e4c2bfb..7a20f68ae206 100644
> --- a/drivers/platform/x86/gpd-pocket-fan.c
> +++ b/drivers/platform/x86/gpd-pocket-fan.c
> @@ -6,6 +6,7 @@
>   */
>  
>  #include <linux/acpi.h>
> +#include <linux/devm-helpers.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
> @@ -124,7 +125,7 @@ static void gpd_pocket_fan_force_update(struct gpd_pocket_fan_data *fan)
>  static int gpd_pocket_fan_probe(struct platform_device *pdev)
>  {
>  	struct gpd_pocket_fan_data *fan;
> -	int i;
> +	int i, ret;
>  
>  	for (i = 0; i < ARRAY_SIZE(temp_limits); i++) {
>  		if (temp_limits[i] < 20000 || temp_limits[i] > 90000) {
> @@ -152,7 +153,10 @@ static int gpd_pocket_fan_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	fan->dev = &pdev->dev;
> -	INIT_DELAYED_WORK(&fan->work, gpd_pocket_fan_worker);
> +	ret = devm_delayed_work_autocancel(&pdev->dev, &fan->work,
> +					   gpd_pocket_fan_worker);
> +	if (ret)
> +		return ret;
>  
>  	/* Note this returns a "weak" reference which we don't need to free */
>  	fan->dts0 = thermal_zone_get_zone_by_name("soc_dts0");
> @@ -177,14 +181,6 @@ static int gpd_pocket_fan_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static int gpd_pocket_fan_remove(struct platform_device *pdev)
> -{
> -	struct gpd_pocket_fan_data *fan = platform_get_drvdata(pdev);
> -
> -	cancel_delayed_work_sync(&fan->work);
> -	return 0;
> -}
> -
>  #ifdef CONFIG_PM_SLEEP
>  static int gpd_pocket_fan_suspend(struct device *dev)
>  {
> @@ -215,7 +211,6 @@ MODULE_DEVICE_TABLE(acpi, gpd_pocket_fan_acpi_match);
>  
>  static struct platform_driver gpd_pocket_fan_driver = {
>  	.probe	= gpd_pocket_fan_probe,
> -	.remove	= gpd_pocket_fan_remove,
>  	.driver	= {
>  		.name			= "gpd_pocket_fan",
>  		.acpi_match_table	= gpd_pocket_fan_acpi_match,
>