linux-kernel - Re: [PATCH v7 1/3] misc/pvpanic: split-up generic and platform dependent code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Mar 2021 16:50:04 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mihai Carabas <mihai.carabas@...cle.com>
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de,
        bobo.shaobowang@...wei.com, rdunlap@...radead.org
Subject: Re: [PATCH v7 1/3] misc/pvpanic: split-up generic and platform
 dependent code

On Tue, Mar 23, 2021 at 03:59:36PM +0200, Mihai Carabas wrote:
> Split-up generic and platform dependent code in order to be able to re-use
> generic event handling code in pvpanic PCI device driver in the next patches.
> 
> The code from pvpanic.c was split in two new files:
> - pvpanic.c: generic code that handles pvpanic events
> - pvpanic-mmio.c: platform/bus dependent code
> 
> Signed-off-by: Mihai Carabas <mihai.carabas@...cle.com>
> ---
>  drivers/misc/Kconfig                |   9 +-
>  drivers/misc/Makefile               |   2 +-
>  drivers/misc/pvpanic.c              | 161 ------------------------------------
>  drivers/misc/pvpanic/Kconfig        |  19 +++++
>  drivers/misc/pvpanic/Makefile       |   7 ++
>  drivers/misc/pvpanic/pvpanic-mmio.c | 135 ++++++++++++++++++++++++++++++
>  drivers/misc/pvpanic/pvpanic.c      |  77 +++++++++++++++++
>  drivers/misc/pvpanic/pvpanic.h      |  15 ++++
>  8 files changed, 255 insertions(+), 170 deletions(-)
>  delete mode 100644 drivers/misc/pvpanic.c
>  create mode 100644 drivers/misc/pvpanic/Kconfig
>  create mode 100644 drivers/misc/pvpanic/Makefile
>  create mode 100644 drivers/misc/pvpanic/pvpanic-mmio.c
>  create mode 100644 drivers/misc/pvpanic/pvpanic.c
>  create mode 100644 drivers/misc/pvpanic/pvpanic.h

With just this commit applied, I get the following build warnings:

drivers/misc/pvpanic/pvpanic-mmio.c:26:22: warning: ‘base’ defined but not used [-Wunused-variable]
   26 | static void __iomem *base;
      |                      ^~~~


ERROR: modpost: missing MODULE_LICENSE() in drivers/misc/pvpanic/pvpanic.o


Remember, each patch needs to work properly and not cause any build
failures or warnings to be added to the tree.

I suggest getting someone else at Oracle to review and test your
patchset before submitting it again so as I don't have to be the ones
finding these types of errors :)

thanks,

greg k-h