linux-kernel - Re: [PATCH] powercap/drivers/dtpm: Add dtpm devfreq with energy model support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a9931f4-ece5-4fe9-5f88-871a2e759200@arm.com>
Date:   Tue, 23 Mar 2021 15:56:17 +0000
From:   Lukasz Luba <lukasz.luba@....com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     cwchoi00@...il.com, myungjoo.ham@...sung.com,
        kyungmin.park@...sung.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, rafael@...nel.org
Subject: Re: [PATCH] powercap/drivers/dtpm: Add dtpm devfreq with energy model
 support

Hi Daniel,

On 3/19/21 4:28 PM, Daniel Lezcano wrote:
> Currently the dtpm supports the CPUs via cpufreq and the energy
> model. This change provides the same for the device which supports
> devfreq.
> 
> Each device supporting devfreq and having an energy model can register
> themselves in the list of supported devices.
> 
> The concept is the same as the cpufreq dtpm support: the QoS is used
> to aggregate the requests and the energy model gives the value of the
> instantaneous power consumption ponderated by the load of the device.
> 

I've just started the review, but I have a blocking question:

Why there is no unregister function (like 'dtmp_unregister_devfreq')?
Do you consider any devfreq drivers to be modules?

The code looks like an API that it's going to be called directly in
e.g. GPU driver in it's probe function. In that case probably the
module unloading should call dtmp unregister.

Could you explain this to me please? So I can continue the review.

Regards,
Lukasz