linux-kernel - Re: [PATCH] dmaengine: plx_dma: add a missing put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <603f6cf3-ed7b-ae5c-6689-f13390385037@deltatee.com>
Date:   Tue, 23 Mar 2021 10:21:37 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Vinod Koul <vkoul@...nel.org>, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] dmaengine: plx_dma: add a missing put_device() on error
 path



On 2021-03-23 7:19 a.m., Dan Carpenter wrote:
> Add a missing put_device(&pdev->dev) if the call to
> dma_async_device_register(dma); fails.
> 
> Fixes: 905ca51e63be ("dmaengine: plx-dma: Introduce PLX DMA engine PCI driver skeleton")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Good catch. Thanks Dan!

Reviewed-by: Logan Gunthorpe <logang@...tatee.com>

Logan