linux-kernel - Re: [PATCH] net/smc: Simplify the return expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <412763fa-f4d6-f0fc-283b-2998be0e0f12@linux.ibm.com>
Date:   Tue, 23 Mar 2021 17:42:35 +0100
From:   Karsten Graul <kgraul@...ux.ibm.com>
To:     zuoqilin1@....com, davem@...emloft.net, kuba@...nel.org
Cc:     linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, zuoqilin <zuoqilin@...ong.com>
Subject: Re: [PATCH] net/smc: Simplify the return expression

On 23/03/2021 03:05, zuoqilin1@....com wrote:
> From: zuoqilin <zuoqilin@...ong.com>
> 
> Simplify the return expression of smc_ism_signal_shutdown().
> 
> Signed-off-by: zuoqilin <zuoqilin@...ong.com>
> ---
>  net/smc/smc_ism.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/net/smc/smc_ism.c b/net/smc/smc_ism.c
> index 9c6e958..c3558cc 100644
> --- a/net/smc/smc_ism.c
> +++ b/net/smc/smc_ism.c
> @@ -344,7 +344,6 @@ static void smcd_handle_sw_event(struct smc_ism_event_work *wrk)
>  
>  int smc_ism_signal_shutdown(struct smc_link_group *lgr)
>  {
> -	int rc;
>  	union smcd_sw_event_info ev_info;
>  
>  	if (lgr->peer_shutdown)
> @@ -353,11 +352,10 @@ int smc_ism_signal_shutdown(struct smc_link_group *lgr)
>  	memcpy(ev_info.uid, lgr->id, SMC_LGR_ID_SIZE);
>  	ev_info.vlan_id = lgr->vlan_id;
>  	ev_info.code = ISM_EVENT_REQUEST;
> -	rc = lgr->smcd->ops->signal_event(lgr->smcd, lgr->peer_gid,
> +	return lgr->smcd->ops->signal_event(lgr->smcd, lgr->peer_gid,
>  					  ISM_EVENT_REQUEST_IR,
>  					  ISM_EVENT_CODE_SHUTDOWN,
>  					  ev_info.info);

I agree with the code change but after I applied your patch the 3 lines above
are no longer correctly indented, please correct that and resend the patch.
Thanks.

> -	return rc;
>  }
>  
>  /* worker for SMC-D events */
> 

-- 
Karsten

(I'm a dude)