linux-kernel - Re: [PATCH] drivers: watchdog: Remove duplicate include of kernel.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a6c9aeff-91d0-9770-f29f-a89b1f3b7f1c@roeck-us.net>
Date:   Mon, 22 Mar 2021 19:14:25 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Wan Jiabing <wanjiabing@...o.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kael_w@...h.net
Subject: Re: [PATCH] drivers: watchdog: Remove duplicate include of kernel.h

On 3/22/21 6:43 PM, Wan Jiabing wrote:
> linux/kernel.h has been included at line 17, so remove the 
> duplicate one at line 22.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  drivers/watchdog/dw_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e1781e63..b1642e2d9175 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -19,7 +19,6 @@
>  #include <linux/delay.h>
>  #include <linux/err.h>
>  #include <linux/io.h>
> -#include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
>  #include <linux/interrupt.h>
> 

The reason for the duplicate include is the non-alphabetic order of include
files. I find that worse than the duplicate include. If it is too much effort
to reorder include files to be in alphabetic order, please at least don't
make it worse and remove the other include.

Guenter