linux-kernel - Re: [net-next PATCH 2/8] octeontx2-pf: Add ethtool priv flag to control PAM4 on/off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <MWHPR18MB14214BF3FE4059554CDA2A16DE649@MWHPR18MB1421.namprd18.prod.outlook.com>
Date:   Tue, 23 Mar 2021 18:59:39 +0000
From:   Hariprasad Kelam <hkelam@...vell.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
Subject: Re: [net-next PATCH 2/8] octeontx2-pf: Add ethtool priv flag to
 control PAM4 on/off

Hi Andrew,

Please see inline,

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Sunday, March 21, 2021 7:58 PM
> To: Hariprasad Kelam <hkelam@...vell.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; kuba@...nel.org;
> davem@...emloft.net; Sunil Kovvuri Goutham <sgoutham@...vell.com>;
> Linu Cherian <lcherian@...vell.com>; Geethasowjanya Akula
> <gakula@...vell.com>; Jerin Jacob Kollanukkaran <jerinj@...vell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
> Subject:  Re: [net-next PATCH 2/8] octeontx2-pf: Add ethtool priv flag to
> control PAM4 on/off
> 
> On Sun, Mar 21, 2021 at 05:39:52PM +0530, Hariprasad Kelam wrote:
> > From: Felix Manlunas <fmanlunas@...vell.com>
> >
> > For PHYs that support changing modulation type (NRZ or PAM4), enable
> > these
> > commands:
> >
> >         ethtool --set-priv-flags  ethX pam4 on
> >         ethtool --set-priv-flags  ethX pam4 off    # means NRZ modulation
> >         ethtool --show-priv-flags ethX
> 
> Why is this not derived from the link mode? How do other Vendors support
> this in their high speed MAC/PHY combinations.
> 
> Please stop using priv flags like this. This is not a Marvell specific problem.
> Any high speed MAC/PHY combination is going to need some way to
> configure this. So please think about the best generic solution.
> 
> This combined with your DSA changes give me a bad feeling. It seems like you
> are just trying to dump your SDK features into the kernel, without properly
> integrating the features in a vendor neutral way.
> 

Thanks for your suggestion .  Will try to evaluate this can be achieved through link mode or any generic solution.
Will try to submit his feature as a separate patch.

Thanks,
Hariprasad k
> 	Andrew