linux-kernel - Re: [PATCH] asus-laptop: fix kobj_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e2b729c-11c7-cdf9-18cc-8d3aa988e134@redhat.com>
Date:   Tue, 23 Mar 2021 21:00:42 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Julia Lawall <julia.lawall@...ia.fr>,
        Corentin Chary <corentin.chary@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        acpi4asus-user@...ts.sourceforge.net
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild-all@...ts.01.org, Denis Efremov <efremov@...ux.com>
Subject: Re: [PATCH] asus-laptop: fix kobj_to_dev.cocci warnings

Hi,

On 3/17/21 1:00 PM, Julia Lawall wrote:
> From: kernel test robot <lkp@...el.com>
> 
> Use kobj_to_dev() instead of container_of()
> 
> Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
> 
> CC: Denis Efremov <efremov@...ux.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   1df27313f50a57497c1faeb6a6ae4ca939c85a7d
> commit: a2fc3718bc22e85378085568ecc5765fb28cabce coccinelle: api: add kobj_to_dev.cocci script
> :::::: branch date: 5 hours ago
> :::::: commit date: 7 months ago
> 
>  asus-laptop.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -1569,7 +1569,7 @@ static umode_t asus_sysfs_is_visible(str
>  				    struct attribute *attr,
>  				    int idx)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct asus_laptop *asus = dev_get_drvdata(dev);
>  	acpi_handle handle = asus->handle;
>  	bool supported;
>