linux-kernel - Re: [PATCH 2/6] dt-bindings: i2c: convert i2c-mpc to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Mar 2021 20:22:00 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Rob Herring <robh@...nel.org>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "wsa@...nel.org" <wsa@...nel.org>,
        "jdelvare@...e.com" <jdelvare@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/6] dt-bindings: i2c: convert i2c-mpc to json-schema

Hi Rob,

On 24/03/21 9:16 am, Rob Herring wrote:
> On Tue, 23 Mar 2021 17:33:27 +1300, Chris Packham wrote:
>> Convert i2c-mpc to YAML.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> ---
>>   .../devicetree/bindings/i2c/i2c-mpc.txt       | 62 ------------
>>   .../devicetree/bindings/i2c/i2c-mpc.yaml      | 99 +++++++++++++++++++
>>   2 files changed, 99 insertions(+), 62 deletions(-)
>>   delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-mpc.txt
>>   create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mpc.yaml
>>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/i2c/i2c-mpc.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> ./Documentation/devicetree/bindings/i2c/i2c-mpc.yaml:20:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
Hmm I did run 'make dt_binding_check' is yamllint run separately (or not 
run if it's not installed?).
> dtschema/dtc warnings/errors:
>
> See https://patchwork.ozlabs.org/patch/1457053
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
Should be easy to fix the binding but I'll spend a bit of time trying to 
get my tooling sorted.