linux-kernel - Re: [PATCH v3 2/3] input: gpio-keys: Use hrtimer for release timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFpesNC3mjqqLf8v@google.com>
Date:   Tue, 23 Mar 2021 14:33:36 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     od@...c.me, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/3] input: gpio-keys: Use hrtimer for release timer

On Sun, Mar 07, 2021 at 10:22:39PM +0000, Paul Cercueil wrote:
> Dealing with input, timing is important; if the button should be
> released in one millisecond, then it should be done in one millisecond
> and not a hundred milliseconds.
> 
> Therefore, the standard timer API is not really suitable for this task.
> 
> Convert the gpio-keys driver to use a hrtimer instead of the standard
> timer to address this issue.
> 
> Note that by using a hard IRQ for the hrtimer callback, we can get rid
> of the spin_lock_irqsave() and spin_unlock_irqrestore().
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>

Applied, thank you.

-- 
Dmitry