linux-kernel - Re: [PATCH 07/18] f2fs: convert to miscattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFk2JPmc7X7GFXni@gmail.com>
Date:   Mon, 22 Mar 2021 17:28:20 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Miklos Szeredi <mszeredi@...hat.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jaegeuk Kim <jaegeuk@...nel.org>
Subject: Re: [PATCH 07/18] f2fs: convert to miscattr

On Wed, Feb 03, 2021 at 01:41:01PM +0100, Miklos Szeredi wrote:
> @@ -3071,123 +3012,54 @@ static int f2fs_ioc_setproject(struct file *filp, __u32 projid)
>  }
>  #endif
>  
> -/* FS_IOC_FSGETXATTR and FS_IOC_FSSETXATTR support */
> -
> -/*
> - * To make a new on-disk f2fs i_flag gettable via FS_IOC_FSGETXATTR and settable
> - * via FS_IOC_FSSETXATTR, add an entry for it to f2fs_xflags_map[], and add its
> - * FS_XFLAG_* equivalent to F2FS_SUPPORTED_XFLAGS.
> - */
> -
> -static const struct {
> -	u32 iflag;
> -	u32 xflag;
> -} f2fs_xflags_map[] = {
> -	{ F2FS_SYNC_FL,		FS_XFLAG_SYNC },
> -	{ F2FS_IMMUTABLE_FL,	FS_XFLAG_IMMUTABLE },
> -	{ F2FS_APPEND_FL,	FS_XFLAG_APPEND },
> -	{ F2FS_NODUMP_FL,	FS_XFLAG_NODUMP },
> -	{ F2FS_NOATIME_FL,	FS_XFLAG_NOATIME },
> -	{ F2FS_PROJINHERIT_FL,	FS_XFLAG_PROJINHERIT },
> -};

There's another comment just above which talks about FS_IOC_GETFLAGS and
FS_IOC_SETFLAGS:

	/* FS_IOC_GETFLAGS and FS_IOC_SETFLAGS support */

	/*
	 * To make a new on-disk f2fs i_flag gettable via FS_IOC_GETFLAGS, add an entry
	 * for it to f2fs_fsflags_map[], and add its FS_*_FL equivalent to
	 * F2FS_GETTABLE_FS_FL.  To also make it settable via FS_IOC_SETFLAGS, also add
	 * its FS_*_FL equivalent to F2FS_SETTABLE_FS_FL.
	 */

This patch seems to make that outdated, since now both FS_IOC_[GS]ETFLAGS and
FS_IOC_[GS]ETFSXATTR are handled together.

Can you please update the comment to properly describe what's going on?

- Eric