lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210323053231.GT2696@paulmck-ThinkPad-P72>
Date:   Mon, 22 Mar 2021 22:32:31 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu: Fix various typos in comments

On Mon, Mar 22, 2021 at 07:55:05PM -0700, Randy Dunlap wrote:
> On 3/22/21 4:02 PM, Ingo Molnar wrote:
> > 
> > Hi Paul,
> > 
> > Was working on automation to make it a bit more straightforward to fix 
> > typos within comments (which we tend to reintroduce during 
> > development), and here are the ones it found in the RCU code.
> > 
> > Thanks,
> > 
> > 	Ingo
> > 
> > =========>
> > From: Ingo Molnar <mingo@...nel.org>
> > Date: Mon, 22 Mar 2021 23:57:26 +0100
> > Subject: [PATCH] rcu: Fix various typos in comments
> > 
> > Fix ~12 single-word typos in RCU code comments.
> > 
> > Signed-off-by: Ingo Molnar <mingo@...nel.org>
> > Cc: Paul E. McKenney <paulmck@...nel.org>
> > Cc: linux-kernel@...r.kernel.org
> > ---
> >  kernel/rcu/srcutree.c                                           | 4 ++--
> >  kernel/rcu/sync.c                                               | 2 +-
> >  kernel/rcu/tasks.h                                              | 8 ++++----
> >  kernel/rcu/tree.c                                               | 4 ++--
> >  kernel/rcu/tree.h                                               | 2 +-
> >  kernel/rcu/tree_plugin.h                                        | 2 +-
> >  tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/locks.h | 2 +-
> >  7 files changed, 12 insertions(+), 12 deletions(-)
> 
> > diff --git a/kernel/rcu/sync.c b/kernel/rcu/sync.c
> > index d4558ab7a07d..3eeb871cf0de 100644
> > --- a/kernel/rcu/sync.c
> > +++ b/kernel/rcu/sync.c
> > @@ -94,7 +94,7 @@ static void rcu_sync_func(struct rcu_head *rhp)
> >  		rcu_sync_call(rsp);
> >  	} else {
> >  		/*
> > -		 * We're at least a GP after the last rcu_sync_exit(); eveybody
> > +		 * We're at least a GP after the last rcu_sync_exit(); everybody
> >  		 * will now have observed the write side critical section.
> >  		 * Let 'em rip!.
> 
> 		Drop the '.'.
> 
> >  		 */
> Otherwise LGTM. Thanks.
> 
> Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Applied, dropping the "." and adding the Reviewed-by.

Thank you both!

							Thanx, Paul

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ