[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <SJ0PR19MB452877CA9A69970F750EB64184649@SJ0PR19MB4528.namprd19.prod.outlook.com>
Date: Tue, 23 Mar 2021 06:22:21 +0000
From: "Yuan, Perry" <Perry.Yuan@...l.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
Perry Yuan <perry979106@...il.com>,
"pobrn@...tonmail.com" <pobrn@...tonmail.com>,
"oder_chiou@...ltek.com" <oder_chiou@...ltek.com>,
"perex@...ex.cz" <perex@...ex.cz>,
"tiwai@...e.com" <tiwai@...e.com>,
"hdegoede@...hat.com" <hdegoede@...hat.com>,
"mgross@...ux.intel.com" <mgross@...ux.intel.com>,
"Limonciello, Mario" <Mario.Limonciello@...l.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
"broonie@...nel.org" <broonie@...nel.org>,
"lgirdwood@...il.com" <lgirdwood@...il.com>,
"platform-driver-x86@...r.kernel.org"
<platform-driver-x86@...r.kernel.org>
Subject: RE: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell
hardware privacy
Hi Pierre:
> -----Original Message-----
> From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> Sent: Monday, March 22, 2021 10:50 PM
> To: Perry Yuan; Yuan, Perry; pobrn@...tonmail.com;
> oder_chiou@...ltek.com; perex@...ex.cz; tiwai@...e.com;
> hdegoede@...hat.com; mgross@...ux.intel.com; Limonciello, Mario
> Cc: linux-kernel@...r.kernel.org; alsa-devel@...a-project.org;
> broonie@...nel.org; lgirdwood@...il.com; platform-driver-
> x86@...r.kernel.org
> Subject: Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell
> hardware privacy
>
>
> [EXTERNAL EMAIL]
>
>
> > As you suggested,I should add the alignment change in another patch.
> > But if i keep the old alignment, the code will be very odd.
> > Seems like that I have to change the below code to new alignment in
> > this patch.
> >
> > if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) &&
> > dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) { <<--- changed
> > back
> > if (!privacy_valid)
> > has_privacy = true;
> > else
> > has_privacy = false;
> > if (!has_privacy) {
> > micmute_led_cdev.brightness <<----------- new alignment
> > ...
> > }
> > ...
> > }
>
> I don't get the point, sorry. The code above doesn't seem properly indented
> or there were spurious tab/spaces conversions?
Could you help to take a look the V5 patch ?
I recovery some part of original code alignment and add my new codes with new Tabs added
Thank you !
Perry
Powered by blists - more mailing lists