linux-kernel - Re: [PATCH] mm: process_vm_access: Remove duplicate include of compat.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a96d8bf1-292f-a239-fc31-1022c7c4a296@huawei.com>
Date:   Tue, 23 Mar 2021 14:33:14 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Wan Jiabing <wanjiabing@...o.com>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     <kael_w@...h.net>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: process_vm_access: Remove duplicate include of
 compat.h

On 2021/3/23 11:23, Wan Jiabing wrote:
> linux/compat.h has been included at line 8.So we remove 
> the duplicate one at line 12.
> 

line 12 one is added via eb351d75ce1e ("mm/process_vm_access.c: include compat.h") to fix the build error:
 mm/process_vm_access.c:277:5: error: implicit declaration of function 'in_compat_syscall'; did you mean 'in_ia32_syscall'? [-Werror=implicit-function-declaration]

There might be something wrong.

> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  mm/process_vm_access.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c
> index f5fee9cf90f8..4bcc11958089 100644
> --- a/mm/process_vm_access.c
> +++ b/mm/process_vm_access.c
> @@ -9,7 +9,6 @@
>  #include <linux/mm.h>
>  #include <linux/uio.h>
>  #include <linux/sched.h>
> -#include <linux/compat.h>
>  #include <linux/sched/mm.h>
>  #include <linux/highmem.h>
>  #include <linux/ptrace.h>
>