linux-kernel - Re: [PATCH 03/11] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFmVIvVz87nJFw0O@kroah.com>
Date:   Tue, 23 Mar 2021 08:13:38 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Fabio Aiuto <fabioaiuto83@...il.com>
Cc:     joe@...ches.com, apw@...onical.com, devel@...verdev.osuosl.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/11] staging: rtl8723bs: moved function prototype out
 of core/rtw_ioctl_set.c and core/rtw_mlme.c

On Mon, Mar 22, 2021 at 07:28:42PM +0100, Fabio Aiuto wrote:
> On Mon, Mar 22, 2021 at 05:09:00PM +0100, Greg KH wrote:
> > On Mon, Mar 22, 2021 at 03:31:41PM +0100, Fabio Aiuto wrote:
> > > fix the following checkpatch issues:
> > > 
> > > WARNING: externs should be avoided in .c files
> > > 40: FILE: drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:40:
> > > +u8 rtw_do_join(struct adapter *padapter);
> > > 
> > > WARNING: externs should be avoided in .c files
> > > 15: FILE: drivers/staging/rtl8723bs/core/rtw_mlme.c:15:
> > > +extern u8 rtw_do_join(struct adapter *padapter);
> > > 
> > > moved function prototype in include/rtw_ioctl_set.h
> > > 
> > > Signed-off-by: Fabio Aiuto <fabioaiuto83@...il.com>
> > > ---
> > >  drivers/staging/rtl8723bs/core/rtw_ioctl_set.c    | 1 -
> > >  drivers/staging/rtl8723bs/core/rtw_mlme.c         | 2 --
> > >  drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 2 ++
> > >  3 files changed, 2 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> > > index cb14855742f7..7d858cae2395 100644
> > > --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> > > +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> > > @@ -37,7 +37,6 @@ u8 rtw_validate_ssid(struct ndis_802_11_ssid *ssid)
> > >  	return ret;
> > >  }
> > >  
> > > -u8 rtw_do_join(struct adapter *padapter);
> > >  u8 rtw_do_join(struct adapter *padapter)
> > >  {
> > >  	struct list_head	*plist, *phead;
> > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> > > index 95cfef118a94..1ee86ec2dee7 100644
> > > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> > > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> > > @@ -12,8 +12,6 @@
> > >  #include <hal_btcoex.h>
> > >  #include <linux/jiffies.h>
> > >  
> > > -extern u8 rtw_do_join(struct adapter *padapter);
> > > -
> > >  int	rtw_init_mlme_priv(struct adapter *padapter)
> > >  {
> > >  	int	i;
> > > diff --git a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h
> > > index 4b929b84040a..55722c1366aa 100644
> > > --- a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h
> > > +++ b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h
> > > @@ -28,6 +28,8 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u8 *bssid, struct ndis_802_1
> > >  u8 rtw_validate_bssid(u8 *bssid);
> > >  u8 rtw_validate_ssid(struct ndis_802_11_ssid *ssid);
> > >  
> > > +u8 rtw_do_join(struct adapter *padapter);
> > > +
> > 
> > This is already in drivers/staging/rtl8188eu/include/hal_intf.h, why
> > declare it again?
> 
> I didn't check the rtl8188eu for that's not a module rtl8723bs depends on

Ugh, you are right, my fault, sorry for the noise.

greg k-h