linux-kernel - Re: [PATCH 11/17] auxdisplay: ht16k33: Convert to simple i2c probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbb4de359d041ae1b03cab4b0407822f@protonic.nl>
Date:   Tue, 23 Mar 2021 09:31:14 +0100
From:   robin <robin@...tonic.nl>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Rob Herring <robh+dt@...nel.org>, Miguel Ojeda <ojeda@...nel.org>,
        Paul Burton <paulburton@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devicetree@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/17] auxdisplay: ht16k33: Convert to simple i2c probe
 function

On 2021-03-22 15:48, Geert Uytterhoeven wrote:
> ht16k33_probe() does not use the passed i2c_device_id, so the driver 
> can
> be converted trivially to the new-style of i2c probing.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  drivers/auxdisplay/ht16k33.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/auxdisplay/ht16k33.c 
> b/drivers/auxdisplay/ht16k33.c
> index 13d18f218b4d196e..1b67f38109bddba8 100644
> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -381,8 +381,7 @@ static int ht16k33_keypad_probe(struct i2c_client 
> *client,
>  	return input_register_device(keypad->dev);
>  }
> 
> -static int ht16k33_probe(struct i2c_client *client,
> -				  const struct i2c_device_id *id)
> +static int ht16k33_probe(struct i2c_client *client)
>  {
>  	int err;
>  	uint32_t dft_brightness;
> @@ -523,7 +522,7 @@ static const struct of_device_id ht16k33_of_match[] 
> = {
>  MODULE_DEVICE_TABLE(of, ht16k33_of_match);
> 
>  static struct i2c_driver ht16k33_driver = {
> -	.probe		= ht16k33_probe,
> +	.probe_new	= ht16k33_probe,
>  	.remove		= ht16k33_remove,
>  	.driver		= {
>  		.name		= DRIVER_NAME,

Acked-by: Robin van der Gracht <robin@...tonic.nl>