linux-kernel - Re: [PATCH] kernel/signal: Modify the comment of function check_kill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210323085908.wdz6gamyoddhnu7e@wittgenstein>
Date:   Tue, 23 Mar 2021 09:59:08 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     zhouchuangao <zhouchuangao@...o.com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Peter Collingbourne <pcc@...gle.com>,
        Zhiqiang Liu <liuzhiqiang26@...wei.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/signal: Modify the comment of function
 check_kill_permission

On Tue, Mar 23, 2021 at 01:03:56AM -0700, zhouchuangao wrote:
> Maybe it's easier for us to understand the function of
> check_kill_permission.
> 
> Signed-off-by: zhouchuangao <zhouchuangao@...o.com>
> ---
>  kernel/signal.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index f2a1b89..2fbf68a 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -823,8 +823,10 @@ static bool kill_ok_by_cred(struct task_struct *t)
>  }
>  
>  /*
> - * Bad permissions for sending the signal
> - * - the caller must hold the RCU read lock
> + * Check if the signal has permission to kill the process.

Hey,

This phrasing is misleading imho. It's not about whether the signal has
permission but whether the caller has permissions to send the signal.

Christian