linux-kernel - Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Mar 2021 10:13:00 +0100
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     Luca Coelho <luca@...lho.fi>, Kalle Valo <kvalo@...eaurora.org>,
        Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        Chris Murphy <lists@...orremedies.com>
Subject: Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

On Mon, Mar 22, 2021 at 1:13 PM Jiri Kosina <jikos@...nel.org> wrote:
>
> On Sat, 13 Mar 2021, Luca Coelho wrote:
>
> > > > > > > > > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs
> > > > > > > > > disabled (e.g. from LED core). We can't enable BHs in such a situation.
> > > > > > > > >
> > > > > > > > > Turn the unconditional BH-enable/BH-disable code into
> > > > > > > > > hardirq-disable/conditional-enable.
> > > > > > > > >
> > > > > > > > > This fixes the warning below.
> > > > > > > >
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > friendly ping on this one ...
> > > > > > >
> > > > > > > Luca,
> > > > > > >
> > > > > > > Johannes is telling me that he merged this patch internally, but I have no
> > > > > > > idea what is happening to it ... ?
> > > > > > >
> > > > > > > The reported splat is a clear bug, so it should be fixed one way or the
> > > > > > > other.
> > > > > >
> > > > > > Should I take this to wireless-drivers?
> > > > >
> > > > > I can't speak for the maintainers, but as far as I am concerned, it
> > > > > definitely is a 5.12 material, as it fixes real scheduling bug.
> > > >
> > > > Yes, please take this to w-d.  We have a similar patch internally, but
> > > > there's a backlog and it will take me some time to get to it.  I'll
> > > > resolve eventual conflicts when time comes.
> > >
> > > Ok, can I have your ack for patchwork?
> >
> > Sorry, forgot that.
> >
> > Acked-by: Luca Coelho <luciano.coelho@...el.com>
>
> Sorry for sounding like broken record :) but this fix is still not in any
> tree as far as I can tell. And it's fixing real scheduling in atomic bug.
>
> Thanks,
>

[ CC Chris Murphy <lists@...orremedies.com> ]

A week ago Chris sent an email to linux-wireless with pointing to:

https://bugzilla.kernel.org/show_bug.cgi?id=212297

AFAICS, that is the same bug.

- Sedat -