linux-kernel - Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b24adfcd-1dac-581a-93bb-0ce38133bc0f@linaro.org>
Date:   Mon, 22 Mar 2021 19:03:43 -0500
From:   Alex Elder <elder@...aro.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Leon Romanovsky <leon@...nel.org>, davem@...emloft.net,
        kuba@...nel.org, bjorn.andersson@...aro.org, evgreen@...omium.org,
        cpratapa@...eaurora.org, subashab@...eaurora.org, elder@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

On 3/22/21 5:56 PM, Andrew Lunn wrote:
>> The solution is to create a user space tool inside the
>> drivers/net/ipa directory that will link with the kernel
>> source files and will perform all the basic one-time checks
>> I want to make.
> 
> Hi Alex
> 
> Have you found any other driver doing this?  Where do they keep there
> code?
> 
> Could this be a selftest, put somewhere in tools/testing/selftests.
> 
> Or can this be a test kernel module. Eg. we have crypt/testmsg.c which
> runs a number of tests on the crypto subsystem,
> ./kernel/time/test_udelay.c which runs times on udelay.
> 
> Rather than inventing something new, please follow other examples
> already in the kernel.

I will.  I did see the tools/testing directory and I'll
look at how people have done things there.

I need to try to get it working first, then I'll figure
out where it belongs.  I think I'll be able to do a user
space test, but it's a little tricky to be sure it's
actually testing what I want.  If that ends up being
too hard, I'll look into kernel test module.

Thanks for the suggestions.

					-Alex

>         Andrew
>