linux-kernel - Re: [PATCH 3/3] w1: ds2438: adding support for accessing page1 registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Mar 2021 10:42:32 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Luiz Sampaio <sampaio.ime@...il.com>
Cc:     zbr@...emap.net, rikard.falkeborn@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] w1: ds2438: adding support for accessing page1
 registers

On Mon, Mar 22, 2021 at 11:44:10PM -0300, Luiz Sampaio wrote:
> @@ -395,6 +483,8 @@ static BIN_ATTR_RO(vdd, 0/* real length varies */);
>  static struct bin_attribute *w1_ds2438_bin_attrs[] = {
>  	&bin_attr_iad,
>  	&bin_attr_page0,
> +	&bin_attr_page1,
> +	&bin_attr_offset,

You are adding new sysfs files, but no new Documentation/ABI entries :(

please fix that up for your next submission.

thanks,

greg k-h