linux-kernel - Re: [PATCH 10/11] pragma once: delete few backslashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Mar 2021 11:09:16 +0100
From:   Pavel Machek <pavel@....cz>
To:     Edward Cree <ecree.xilinx@...il.com>
Cc:     Alexey Dobriyan <adobriyan@...il.com>,
        torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, vgupta@...opsys.com,
        linux-snps-arc@...ts.infradead.org, jiri@...dia.com,
        idosch@...dia.com, netdev@...r.kernel.org, Jason@...c4.com,
        mchehab@...nel.org
Subject: Re: [PATCH 10/11] pragma once: delete few backslashes

Hi!
> > index e201b4b1655a..46704c341b17 100644
> > --- a/arch/arc/include/asm/cacheflush.h
> > +++ b/arch/arc/include/asm/cacheflush.h
> > @@ -112,6 +112,6 @@ do {									\
> >  } while (0)
> >  
> >  #define copy_from_user_page(vma, page, vaddr, dst, src, len)		\
> > -	memcpy(dst, src, len);						\
> > +	memcpy(dst, src, len)
> >  This changebar also removes a semicolon.
> It looks plausibly correct, but the commit message ought to mention it.

Probably should use do{}while(0) trick.
										Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)