linux-kernel - Re: [PATCH 1/2] drivers: misc: kgdbts.c: Fix declaration warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YFnlADClpqE9Zkom@kroah.com>
Date:   Tue, 23 Mar 2021 13:54:24 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Shubhankar Kuranagatti <shubhankarvk@...il.com>
Cc:     jason.wessel@...driver.com, dianders@...omium.org, arnd@...db.de,
        kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
        bkkarthik@...u.pes.edu
Subject: Re: [PATCH 1/2] drivers: misc: kgdbts.c: Fix declaration warning.

On Sun, Mar 14, 2021 at 03:28:08AM +0530, Shubhankar Kuranagatti wrote:
> A new line has been added after declaration. This is done to
> maintain code uniformity.
> 
> Signed-off-by: Shubhankar Kuranagatti <shubhankarvk@...il.com>
> ---
>  drivers/misc/kgdbts.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c
> index 945701bce553..3ee5acc1c391 100644
> --- a/drivers/misc/kgdbts.c
> +++ b/drivers/misc/kgdbts.c
> @@ -474,6 +474,7 @@ static int emul_sstep_put(char *put_str, char *arg)
>  {
>  	if (!arch_needs_sstep_emulation) {
>  		char *ptr = &put_str[11];
> +
>  		if (put_str[1] != 'T' || put_str[2] != '0')
>  			return 1;
>  		kgdb_hex2long(&ptr, &sstep_thread_id);
> @@ -502,6 +503,7 @@ static int emul_sstep_put(char *put_str, char *arg)
>  			return 1;
>  		} else {
>  			char *ptr = &put_str[11];
> +
>  			kgdb_hex2long(&ptr, &sstep_thread_id);
>  		}
>  		break;
> @@ -740,6 +742,7 @@ static int validate_simple_test(char *put_str)
>  static int run_simple_test(int is_get_char, int chr)
>  {
>  	int ret = 0;
> +
>  	if (is_get_char) {
>  		/* Send an ACK on the get if a prior put completed and set the			* send ack variable
> --
> 2.17.1

This patch is corrupted :(

Please fix up and resend the whole series properly threaded so our tools
can pick them both up at the same time.

thanks,

greg k-h