linux-kernel - Re: [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Mar 2021 14:18:51 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Abhishek C <astro.abhishek02@...il.com>
Cc:     devel@...verdev.osuosl.org, tkjos@...roid.com, surenb@...gle.com,
        bkkarthik@...u.pes.edu, linux-kernel@...r.kernel.org,
        hridya@...gle.com, arve@...roid.com, joel@...lfernandes.org,
        maco@...roid.com, christian@...uner.io
Subject: Re: [PATCH] drivers: android: binder.c: Fix indentation of
 multi-line comment

On Sat, Mar 13, 2021 at 09:46:55PM +0530, Abhishek C wrote:
> Fixed alignment of multi-line comment.
> Added a * for each line of the comment.
> 
> Signed-off-by: Abhishek C <astro.abhishek02@...il.com>
> ---
>  drivers/android/binder.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index c119736ca56a..700719c58147 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -4617,8 +4617,9 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>  	unsigned int size = _IOC_SIZE(cmd);
>  	void __user *ubuf = (void __user *)arg;
>  
> -	/*pr_info("binder_ioctl: %d:%d %x %lx\n",
> -			proc->pid, current->pid, cmd, arg);*/
> +	/* pr_info("binder_ioctl: %d:%d %x %lx\n",
> +	 * proc->pid, current->pid, cmd, arg);
> +	 */

This looks like left-over debugging code, and as-is, is formatted
properly.

Why not just delete it entirely?  If someone needs debugging code, they
can add it back in.

thanks,

greg k-h