[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210323132551.GK2026@agape.jhs>
Date: Tue, 23 Mar 2021 14:25:52 +0100
From: Fabio Aiuto <fabioaiuto83@...il.com>
To: Dan Carpenter <dan.carpenter@...cle.com>
Cc: gregkh@...uxfoundation.org, joe@...ches.com, apw@...onical.com,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out
of core/rtw_efuse.c
On Mon, Mar 22, 2021 at 10:29:27PM +0300, Dan Carpenter wrote:
> On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote:
> > fix the following checkpatch issues:
> >
> > WARNING: externs should be avoided in .c files
> > 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35:
> > +bool
> >
> > moved two function prototypes in include/rtw_efuse.h
>
> Can't you just make these functions static instead?
>
> regards,
> dan carpenter
>
Hi Dan,
sorry for my recent spamming, I forgot to cc you in my
patchset v2 submit.
Thank you,
fabio
Powered by blists - more mailing lists