linux-kernel - Re: [PATCH] Input: i8042 - fix Pegatron C15B ID entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Mar 2021 11:42:23 -0300
From:   Marcos Paulo de Souza <mpdesouza@...e.de>
To:     Arnd Bergmann <arnd@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Marcos Paulo de Souza <mpdesouza@...e.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Po-Hsu Lin <po-hsu.lin@...onical.com>,
        Kevin Locke <kevin@...inlocke.name>,
        Hans de Goede <hdegoede@...hat.com>,
        Alexey Dobriyan <adobriyan@...il.com>,
        David Pedersen <limero1337@...il.com>,
        Rajat Jain <rajatja@...gle.com>,
        Chris Chiu <chiu@...lessos.org>, Jiri Kosina <jkosina@...e.cz>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: i8042 - fix Pegatron C15B ID entry

On Tue, 2021-03-23 at 14:06 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The Zenbook Flip entry that was added overwrites a previous one
> because of a typo:
> 
> In file included from drivers/input/serio/i8042.h:23,
>                  from drivers/input/serio/i8042.c:131:
> drivers/input/serio/i8042-x86ia64io.h:591:28: error: initialized
> field overwritten [-Werror=override-init]
>   591 |                 .matches = {
>       |                            ^
> drivers/input/serio/i8042-x86ia64io.h:591:28: note: (near
> initialization for 'i8042_dmi_noselftest_table[0].matches')
> 
> Add the missing separator between the two.

Oops, my bad...

Thanks for fixing it Arnd.

Reviewed-by: Marcos Paulo de Souza <mpdesouza@...e.com>

> 
> Fixes: b5d6e7ab7fe7 ("Input: i8042 - add ASUS Zenbook Flip to
> noselftest list")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/input/serio/i8042-x86ia64io.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/serio/i8042-x86ia64io.h
> b/drivers/input/serio/i8042-x86ia64io.h
> index 9119e12a5778..a5a003553646 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -588,6 +588,7 @@ static const struct dmi_system_id
> i8042_dmi_noselftest_table[] = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER
> INC."),
>  			DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /* Notebook
> */
>  		},
> +	}, {
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER
> INC."),
>  			DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*
> Convertible Notebook */