linux-kernel - Re: [PATCH] locking/mutex: Remove repeated declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18e11fe3-5866-f46a-9366-a5065d2147ed@hisilicon.com>
Date:   Wed, 24 Mar 2021 10:49:43 +0800
From:   Shaokun Zhang <zhangshaokun@...ilicon.com>
To:     Ingo Molnar <mingo@...nel.org>
CC:     <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
        Waiman Long <longman@...hat.com>,
        Boqun Feng <boqun.feng@...il.com>
Subject: Re: [PATCH] locking/mutex: Remove repeated declaration

Hi Ingo,

On 2021/3/23 19:23, Ingo Molnar wrote:
> 
> * Shaokun Zhang <zhangshaokun@...ilicon.com> wrote:
> 
>> Commit 0cd39f4600ed ("locking/seqlock, headers: Untangle the spaghetti monster")
>> introduces 'struct ww_acquire_ctx' again, remove the repeated declaration.
>>
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: Will Deacon <will@...nel.org>
>> Cc: Waiman Long <longman@...hat.com>
>> Cc: Boqun Feng <boqun.feng@...il.com>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@...ilicon.com>
>> ---
>>  include/linux/mutex.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/include/linux/mutex.h b/include/linux/mutex.h
>> index 0cd631a19727..d80c0e22c822 100644
>> --- a/include/linux/mutex.h
>> +++ b/include/linux/mutex.h
>> @@ -20,8 +20,6 @@
>>  #include <linux/osq_lock.h>
>>  #include <linux/debug_locks.h>
>>  
>> -struct ww_acquire_ctx;
>> -
>>  /*
>>   * Simple, straightforward mutexes with strict semantics:
>>   *
> 
> Please also group the pre-declarations together, that's the canonical 
> pattern we use in headers.

Ok,

> 
> I.e. have something like this at the top:
> 

Got it, I will do it in next version.

Thanks,
Shaokun

>   struct ww_class;
>   struct ww_acquire_ctx;
> 
> Thanks,
> 
> 	Ingo
> .
>