linux-kernel - Re: [PATCHv3 4/6] arm64: entry: factor irq triage logic into macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210324165629.GC13030@willie-the-truck>
Date:   Wed, 24 Mar 2021 16:56:30 +0000
From:   Will Deacon <will@...nel.org>
To:     Mark Rutland <mark.rutland@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        catalin.marinas@....com, james.morse@....com, marcan@...can.st,
        maz@...nel.org, tglx@...utronix.de
Subject: Re: [PATCHv3 4/6] arm64: entry: factor irq triage logic into macros

On Mon, Mar 15, 2021 at 11:56:27AM +0000, Mark Rutland wrote:
> From: Marc Zyngier <maz@...nel.org>
> 
> In subsequent patches we'll allow an FIQ handler to be registered, and
> FIQ exceptions will need to be triaged very similarly to IRQ exceptions.
> So that we can reuse the existing logic, this patch factors the IRQ
> triage logic out into macros that can be reused for FIQ.
> 
> The macros are named to follow the elX_foo_handler scheme used by the C
> exception handlers. For consistency with other top-level exception
> handlers, the kernel_entry/kernel_exit logic is not moved into the
> macros. As FIQ will use a different C handler, this handler name is
> provided as an argument to the macros.
> 
> There should be no functional change as a result of this patch.
> 
> Signed-off-by: Marc Zyngier <maz@...nel.org>
> [Mark: rework macros, commit message, rebase before DAIF rework]
> Signed-off-by: Mark Rutland <mark.rutland@....com>
> Tested-by: Hector Martin <marcan@...can.st>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: James Morse <james.morse@....com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Will Deacon <will@...nel.org>
> ---
>  arch/arm64/kernel/entry.S | 80 +++++++++++++++++++++++++----------------------
>  1 file changed, 43 insertions(+), 37 deletions(-)

Acked-by: Will Deacon <will@...nel.org>

Will