linux-kernel - Re: [PATCH] rhashtable: avoid -Wrestrict warning on overlapping sprintf output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <161662440920.20293.8537957789439812189.git-patchwork-notify@kernel.org>
Date:   Wed, 24 Mar 2021 22:20:09 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     tgraf@...g.ch, herbert@...dor.apana.org.au, arnd@...db.de,
        colin.king@...onical.com, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rhashtable: avoid -Wrestrict warning on overlapping sprintf
 output

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 23 Mar 2021 14:03:32 +0100 you wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> sprintf() is declared with a restrict keyword to not allow input and
> output to point to the same buffer:
> 
> lib/test_rhashtable.c: In function 'print_ht':
> lib/test_rhashtable.c:504:4: error: 'sprintf' argument 3 overlaps destination object 'buff' [-Werror=restrict]
>   504 |    sprintf(buff, "%s\nbucket[%d] -> ", buff, i);
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/test_rhashtable.c:489:7: note: destination object referenced by 'restrict'-qualified argument 1 was declared here
>   489 |  char buff[512] = "";
>       |       ^~~~
> 
> [...]

Here is the summary with links:
  - rhashtable: avoid -Wrestrict warning on overlapping sprintf output
    https://git.kernel.org/netdev/net-next/c/4adec7f81df8

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html