linux-kernel - Re: [PATCH -next] x86/kprobes: Fix old-style-declaration warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210325074906.27fb5fd5528da9b3bee72d53@kernel.org>
Date:   Thu, 25 Mar 2021 07:49:06 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     'Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        "Ingo Molnar" <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        <x86@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Mike Rapoport <rppt@...nel.org>, Jiri Olsa <jolsa@...hat.com>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        "Hulk Robot" <hulkci@...wei.com>
Subject: Re: [PATCH -next] x86/kprobes: Fix old-style-declaration warning

On Wed, 24 Mar 2021 14:45:02 +0000
'Wei Yongjun <weiyongjun1@...wei.com> wrote:

> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> Gcc reports build warning as follows:
> 
> arch/x86/kernel/kprobes/core.c:940:1:
>  warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
>   940 | static int nokprobe_inline kprobe_is_ss(struct kprobe_ctlblk *kcb)
>       | ^~~~~~
> 
> This commit fix it by moving nokprobe_inline to the beginning
> of declaration.
> 

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you!

> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  arch/x86/kernel/kprobes/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
> index 89d9f26785c7..5abf251f12ec 100644
> --- a/arch/x86/kernel/kprobes/core.c
> +++ b/arch/x86/kernel/kprobes/core.c
> @@ -937,7 +937,7 @@ static int reenter_kprobe(struct kprobe *p, struct pt_regs *regs,
>  }
>  NOKPROBE_SYMBOL(reenter_kprobe);
>  
> -static int nokprobe_inline kprobe_is_ss(struct kprobe_ctlblk *kcb)
> +static nokprobe_inline int kprobe_is_ss(struct kprobe_ctlblk *kcb)
>  {
>  	return (kcb->kprobe_status == KPROBE_HIT_SS ||
>  		kcb->kprobe_status == KPROBE_REENTER);
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>