[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <543bd87e-5059-002b-4cc4-a262fe5eb1ff@infradead.org>
Date: Wed, 24 Mar 2021 16:17:26 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Ingo Molnar <mingo@...nel.org>,
Arnaldo Carvalho de Melo <acme@...radead.org>
Cc: linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH, -v2] perf tools: Fix various typos in comments
On 3/23/21 9:09 AM, Ingo Molnar wrote:
>
> * Ingo Molnar <mingo@...nel.org> wrote:
>
>> Fix ~81 single-word typos in the perf tooling code - accumulated over the years.
>
> Found a few more:
>
> =============>
> From: Ingo Molnar <mingo@...nel.org>
> Date: Sun, 21 Mar 2021 12:37:34 +0100
> Subject: [PATCH] perf tools: Fix various typos in comments
>
> Fix ~124 single-word typos and a few spelling errors in the perf tooling code,
> accumulated over the years.
>
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> Link: https://lore.kernel.org/r/20210321113734.GA248990@gmail.com
> ---
> tools/perf/Documentation/perf-buildid-cache.txt | 2 +-
> tools/perf/Documentation/perf-report.txt | 2 +-
> tools/perf/Documentation/perf-top.txt | 2 +-
> tools/perf/arch/arm/util/cs-etm.c | 2 +-
> tools/perf/arch/arm64/util/machine.c | 8 ++++----
> tools/perf/arch/arm64/util/perf_regs.c | 2 +-
> tools/perf/arch/powerpc/util/kvm-stat.c | 2 +-
> tools/perf/arch/powerpc/util/utils_header.h | 2 +-
> tools/perf/arch/x86/tests/bp-modify.c | 2 +-
> tools/perf/arch/x86/util/perf_regs.c | 4 ++--
> tools/perf/bench/epoll-wait.c | 4 ++--
> tools/perf/bench/numa.c | 2 +-
> tools/perf/builtin-annotate.c | 2 +-
> tools/perf/builtin-diff.c | 2 +-
> tools/perf/builtin-lock.c | 2 +-
> tools/perf/builtin-sched.c | 2 +-
> tools/perf/builtin-script.c | 4 ++--
> tools/perf/builtin-stat.c | 4 ++--
> tools/perf/builtin-top.c | 2 +-
> tools/perf/examples/bpf/augmented_raw_syscalls.c | 4 ++--
> tools/perf/jvmti/jvmti_agent.c | 4 ++--
> tools/perf/pmu-events/arch/powerpc/power8/metrics.json | 12 ++++++------
> tools/perf/pmu-events/arch/powerpc/power9/metrics.json | 2 +-
> tools/perf/pmu-events/jevents.c | 2 +-
> tools/perf/scripts/python/netdev-times.py | 2 +-
> tools/perf/tests/bp_signal.c | 6 +++---
> tools/perf/tests/code-reading.c | 2 +-
> tools/perf/tests/hists_cumulate.c | 4 ++--
> tools/perf/tests/parse-events.c | 2 +-
> tools/perf/tests/parse-metric.c | 2 +-
> tools/perf/tests/topology.c | 2 +-
> tools/perf/trace/beauty/include/linux/socket.h | 2 +-
> tools/perf/ui/browsers/annotate.c | 2 +-
> tools/perf/ui/browsers/hists.c | 2 +-
> tools/perf/util/bpf-loader.c | 2 +-
> tools/perf/util/call-path.h | 2 +-
> tools/perf/util/callchain.c | 2 +-
> tools/perf/util/config.c | 2 +-
> tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 2 +-
> tools/perf/util/cs-etm.c | 8 ++++----
> tools/perf/util/cs-etm.h | 5 +++--
> tools/perf/util/data-convert-bt.c | 2 +-
> tools/perf/util/demangle-java.c | 4 ++--
> tools/perf/util/dso.h | 2 +-
> tools/perf/util/dwarf-aux.c | 6 +++---
> tools/perf/util/dwarf-aux.h | 2 +-
> tools/perf/util/events_stats.h | 2 +-
> tools/perf/util/evlist.c | 2 +-
> tools/perf/util/evsel.c | 4 ++--
> tools/perf/util/expr.h | 2 +-
> tools/perf/util/header.c | 18 +++++++++---------
> tools/perf/util/intel-pt.c | 2 +-
> tools/perf/util/levenshtein.c | 2 +-
> tools/perf/util/libunwind/arm64.c | 2 +-
> tools/perf/util/libunwind/x86_32.c | 2 +-
> tools/perf/util/llvm-utils.c | 2 +-
> tools/perf/util/machine.c | 8 ++++----
> tools/perf/util/map.h | 4 ++--
> tools/perf/util/mem-events.h | 2 +-
> tools/perf/util/metricgroup.c | 2 +-
> tools/perf/util/parse-events.c | 10 +++++-----
> tools/perf/util/pmu.c | 4 ++--
> tools/perf/util/probe-event.c | 4 ++--
> tools/perf/util/probe-finder.c | 6 +++---
> tools/perf/util/s390-cpumsf.c | 10 +++++-----
> tools/perf/util/scripting-engines/trace-event-python.c | 2 +-
> tools/perf/util/session.c | 4 ++--
> tools/perf/util/strbuf.h | 2 +-
> tools/perf/util/strfilter.h | 4 ++--
> tools/perf/util/symbol-elf.c | 2 +-
> tools/perf/util/synthetic-events.c | 4 ++--
> tools/perf/util/unwind-libunwind-local.c | 2 +-
> 72 files changed, 125 insertions(+), 124 deletions(-)
>
> diff --git a/tools/perf/arch/arm64/util/machine.c b/tools/perf/arch/arm64/util/machine.c
> index 40c5e0b5bda8..acdf8dc1189b 100644
> --- a/tools/perf/arch/arm64/util/machine.c
> +++ b/tools/perf/arch/arm64/util/machine.c
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/ SPDX-License-Identifier: GPL-2.0
That is the only problem that I found, and I see that found
that one.
> #include <inttypes.h>
> #include <stdio.h>
Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
(yeah, I'm late)
--
~Randy
Powered by blists - more mailing lists