linux-kernel - Re: [Nouveau] [PATCH -next] drm/nouveau/core/client: Mark nvkm_uclient_sclass with static keyword

Open Source and information security mailing list archives

Message-ID: <CACAvsv4QztVux4VfPjLB4BMeLEL2+LePgFLVDVS7=4GMbx995g@mail.gmail.com>
Date:   Thu, 25 Mar 2021 09:20:21 +1000
From:   Ben Skeggs <skeggsb@...il.com>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     Ben Skeggs <bskeggs@...hat.com>, Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        ML nouveau <nouveau@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [Nouveau] [PATCH -next] drm/nouveau/core/client: Mark
 nvkm_uclient_sclass with static keyword

On Tue, 23 Mar 2021 at 17:03, Zou Wei <zou_wei@...wei.com> wrote:
>
> Fix the following sparse warning:
>
> drivers/gpu/drm/nouveau/nvkm/core/client.c:64:1: warning: symbol 'nvkm_uclient_sclass' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
Applied, thanks.

> ---
>  drivers/gpu/drm/nouveau/nvkm/core/client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/client.c b/drivers/gpu/drm/nouveau/nvkm/core/client.c
> index ac671202919e..0c8c55c73b12 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/core/client.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/core/client.c
> @@ -60,7 +60,7 @@ nvkm_uclient_new(const struct nvkm_oclass *oclass, void *argv, u32 argc,
>         return 0;
>  }
>
> -const struct nvkm_sclass
> +static const struct nvkm_sclass
>  nvkm_uclient_sclass = {
>         .oclass = NVIF_CLASS_CLIENT,
>         .minver = 0,
> --
> 2.17.1
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives