| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Mar 2021 09:28:52 +1000
From: Ben Skeggs <skeggsb@...il.com>
To: ChunyouTang <tangchunyou@....com>
Cc: Ben Skeggs <bskeggs@...hat.com>, Dave Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>, Lyude Paul <lyude@...hat.com>,
ML nouveau <nouveau@...ts.freedesktop.org>,
tangchunyou@...ong.com, LKML <linux-kernel@...r.kernel.org>,
ML dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] nouveau/nvkm/subdev/devinit/mcp89.c:Unneeded variable
On Wed, 17 Mar 2021 at 19:51, ChunyouTang <tangchunyou@....com> wrote:
>
> From: tangchunyou <tangchunyou@...ong.com>
>
> disable,delete disable and return 0
>
> Signed-off-by: tangchunyou <tangchunyou@...ong.com>
Thanks!
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
> index fb90d47..a9cdf24 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
> @@ -32,7 +32,6 @@
> struct nvkm_device *device = init->subdev.device;
> u32 r001540 = nvkm_rd32(device, 0x001540);
> u32 r00154c = nvkm_rd32(device, 0x00154c);
> - u64 disable = 0;
>
> if (!(r001540 & 0x40000000)) {
> nvkm_subdev_disable(device, NVKM_ENGINE_MSPDEC, 0);
> @@ -48,7 +47,7 @@
> if (!(r00154c & 0x00000200))
> nvkm_subdev_disable(device, NVKM_ENGINE_CE, 0);
>
> - return disable;
> + return 0;
> }
>
> static const struct nvkm_devinit_func
> --
> 1.9.1
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Powered by blists - more mailing lists