linux-kernel - Re: [PATCH] drm/radeon/r600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Mar 2021 05:00:39 +0530
From:   Bhaskar Chowdhury <unixbhaskar@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     alexander.deucher@....com, christian.koenig@....com,
        airlied@...ux.ie, daniel@...ll.ch, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/radeon/r600_cs: Couple of typo fixes

On 14:48 Wed 24 Mar 2021, Randy Dunlap wrote:
>On 3/24/21 6:50 AM, Bhaskar Chowdhury wrote:
>>
>> s/miror/mirror/
>> s/needind/needing/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
>> ---
>>  drivers/gpu/drm/radeon/r600_cs.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c
>> index 34b7c6f16479..aded1f2264e0 100644
>> --- a/drivers/gpu/drm/radeon/r600_cs.c
>> +++ b/drivers/gpu/drm/radeon/r600_cs.c
>> @@ -38,7 +38,7 @@ extern void r600_cs_legacy_get_tiling_conf(struct drm_device *dev, u32 *npipes,
>>
>>
>>  struct r600_cs_track {
>> -	/* configuration we miror so that we use same code btw kms/ums */
>> +	/* configuration we mirror so that we use same code btw kms/ums */
>>  	u32			group_size;
>>  	u32			nbanks;
>>  	u32			npipes;
>> @@ -963,7 +963,7 @@ static int r600_cs_parse_packet0(struct radeon_cs_parser *p,
>>   *
>>   * This function will test against r600_reg_safe_bm and return 0
>>   * if register is safe. If register is not flag as safe this function
>> - * will test it against a list of register needind special handling.
>> + * will test it against a list of register needing special handling.
>>   */
>>  static int r600_cs_check_reg(struct radeon_cs_parser *p, u32 reg, u32 idx)
>>  {
>> --
>
>Those 2 LGTM, but please fix this while you are touching this file:
>
>drivers/gpu/drm/radeon/r600_cs.c:2339: informations  ==> information
>
Thanks, I have sent a V2 with the change...
>
>thanks.
>--
>~Randy
>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)