linux-kernel - Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed work init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Mar 2021 07:02:52 +0200
From:   Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>
Cc:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed
 work init

Hello Chanwoo, Greg,

Thanks for the review.

On Wed, 2021-03-24 at 11:09 +0900, Chanwoo Choi wrote:
> Hi,
> 
> Need to fix the work as following:
> s/extconn/extcon
> 
> And I'd like you to use the more correct patch title like the
> following example:
> "extcon: Use resource-managed function for delayed work"

I think Greg merged this already. How should we handle this?

> @@ -112,7 +113,9 @@ static int gpio_extcon_probe(struct
> > platform_device *pdev)
> >  	if (ret < 0)
> >  		return ret;
> >  
> > -	INIT_DELAYED_WORK(&data->work, gpio_extcon_work);
> > +	ret = devm_delayed_work_autocancel(dev, &data->work,
> > gpio_extcon_work);
> > +	if (ret)
> > +		return ret;
> 
> Need to add the error log as following:
> 	if (ret) {
> 		dev_err(dev, "Failed to initialize delayed_work");
> 		return ret;
> 	}	

I could send incremental patch to Greg for this but it does not change
the commit message.

Best Regards
	Matti Vaittinen