linux-kernel - [PATCH 1/2] arm64/process.c: fix Wmissing-prototypes build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1616568899-986-1-git-send-email-maninder1.s@samsung.com>
Date:   Wed, 24 Mar 2021 12:24:58 +0530
From:   Maninder Singh <maninder1.s@...sung.com>
To:     catalin.marinas@....com, will@...nel.org, pcc@...gle.com,
        mark.rutland@....com, akpm@...ux-foundation.org,
        0x7f454c46@...il.com, amit.kachhap@....com, james.morse@....com,
        vincenzo.frascino@....com, nsaenzjulienne@...e.de,
        keescook@...omium.org, samitolvanen@...gle.com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        a.sahrawat@...sung.com, Maninder Singh <maninder1.s@...sung.com>
Subject: [PATCH 1/2] arm64/process.c: fix Wmissing-prototypes build warnings

function protypes are missed before defination, which
leads to compilation warning with "-Wmissing-prototypes"
flag.

https://lkml.org/lkml/2021/3/19/840

arch/arm64/kernel/process.c:261:6: warning: no previous prototype for '__show_regs' [-Wmissing-prototypes]
    261 | void __show_regs(struct pt_regs *regs)
        |      ^~~~~~~~~~~
arch/arm64/kernel/process.c:307:6: warning: no previous prototype for '__show_regs_alloc_free' [-Wmissing-prototypes]
    307 | void __show_regs_alloc_free(struct pt_regs *regs)
        |      ^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/process.c:365:5: warning: no previous prototype for 'arch_dup_task_struct' [-Wmissing-prototypes]
   365 | int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)
        |     ^~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/process.c:546:41: warning: no previous prototype for '__switch_to' [-Wmissing-prototypes]
   546 | __notrace_funcgraph struct task_struct *__switch_to(struct task_struct *prev,
        |                                         ^~~~~~~~~~~
arch/arm64/kernel/process.c:710:25: warning: no previous prototype for 'arm64_preempt_schedule_irq' [-Wmissing-prototypes]
   710 | asmlinkage void __sched arm64_preempt_schedule_irq(void)
        |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~

Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
---
 arch/arm64/include/asm/processor.h   | 2 ++
 arch/arm64/include/asm/thread_info.h | 2 ++
 arch/arm64/kernel/process.c          | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h
index ca2cd75d3286..efc10e9041a0 100644
--- a/arch/arm64/include/asm/processor.h
+++ b/arch/arm64/include/asm/processor.h
@@ -251,6 +251,8 @@ unsigned long get_wchan(struct task_struct *p);
 extern struct task_struct *cpu_switch_to(struct task_struct *prev,
 					 struct task_struct *next);
 
+asmlinkage void arm64_preempt_schedule_irq(void);
+
 #define task_pt_regs(p) \
 	((struct pt_regs *)(THREAD_SIZE + task_stack_page(p)) - 1)
 
diff --git a/arch/arm64/include/asm/thread_info.h b/arch/arm64/include/asm/thread_info.h
index 9f4e3b266f21..6623c99f0984 100644
--- a/arch/arm64/include/asm/thread_info.h
+++ b/arch/arm64/include/asm/thread_info.h
@@ -55,6 +55,8 @@ void arch_setup_new_exec(void);
 #define arch_setup_new_exec     arch_setup_new_exec
 
 void arch_release_task_struct(struct task_struct *tsk);
+int arch_dup_task_struct(struct task_struct *dst,
+				struct task_struct *src);
 
 #endif
 
diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index 325c83b1a24d..6e60aa3b5ea9 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -57,6 +57,8 @@
 #include <asm/processor.h>
 #include <asm/pointer_auth.h>
 #include <asm/stacktrace.h>
+#include <asm/switch_to.h>
+#include <asm/system_misc.h>
 
 #if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_STACKPROTECTOR_PER_TASK)
 #include <linux/stackprotector.h>
-- 
2.17.1