linux-kernel - Re: [PATCH v3] dt-binding: leds: Document leds-multi-gpio bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210324082551.GA15591@amd>
Date:   Wed, 24 Mar 2021 09:25:52 +0100
From:   Pavel Machek <pavel@....cz>
To:     Alexander Dahl <ada@...rsis.com>
Cc:     Hermes Zhang <chenhui.zhang@...s.com>, Dan Murphy <dmurphy@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Hermes Zhang <chenhuiz@...s.com>, kernel@...s.com,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] dt-binding: leds: Document leds-multi-gpio bindings

On Wed 2021-03-24 06:58:21, Alexander Dahl wrote:
> Hello Hermes,
> 
> > Hermes Zhang <chenhui.zhang@...s.com> hat am 24.03.2021 03:48 geschrieben:
> > 
> >  
> > From: Hermes Zhang <chenhuiz@...s.com>
> > 
> > Document the device tree bindings of the multiple GPIOs LED driver
> > Documentation/devicetree/bindings/leds/leds-multi-gpio.yaml.
> > 
> > Signed-off-by: Hermes Zhang <chenhuiz@...s.com>
> > ---
> > 
> > Notes:
> >     Add maxItems
> 
> What about the other part of the series? I think you should send both patches together with an introduction message on both. If you only change one patch for a new version spin of the series, just send the other one unchanged.
>

Please wrap emails after 72 columns or so.

> (It makes no sense to merge the binding as long as the driver is not merged, otherwise you would end up with a binding without driver. So keeping them together should help reviewers and maintainers.)
>

This is actually okay to do if you expect discussion and not a patch
merge. Series works, too.

Best regads,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)