linux-kernel - Re: [PATCH V3 1/2] soc: qcom-geni-se: Cleanup the code to remove proxy votes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f61210c135fdaa742cc4abdfcdebd8ab@codeaurora.org>
Date:   Wed, 24 Mar 2021 15:42:46 +0530
From:   rojay@...eaurora.org
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org, mka@...omium.org,
        robh+dt@...nel.org, linux-serial@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Rajendra Nayak <rnayak@...eaurora.org>,
        akashast@...eaurora.org, msavaliy@....qualcomm.com
Subject: Re: [PATCH V3 1/2] soc: qcom-geni-se: Cleanup the code to remove
 proxy votes

On 2021-03-23 15:00, Greg KH wrote:
> On Mon, Mar 22, 2021 at 04:34:28PM +0530, Roja Rani Yarubandi wrote:
>> This reverts commit 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect
>> support to fix earlycon crash")
>> 
>> ICC core and platforms drivers supports sync_state feature with
>> commit 7d3b0b0d8184 ("interconnect: qcom: Use icc_sync_state") which
>> ensures that the default ICC BW votes from the bootloader is not
>> removed until all it's consumers are probes.
>> 
>> The proxy votes were needed in case other QUP child drivers
>> I2C, SPI probes before UART, they can turn off the QUP-CORE clock
>> which is shared resources for all QUP driver, this causes unclocked
>> access to HW from earlycon.
>> 
>> Given above support from ICC there is no longer need to maintain
>> proxy votes on QUP-CORE ICC node from QUP wrapper driver for early
>> console usecase, the default votes won't be removed until real
>> console is probed.
>> 
>> Signed-off-by: Roja Rani Yarubandi <rojay@...eaurora.org>
>> Signed-off-by: Akash Asthana <akashast@...eaurora.org>
>> Reviewed-by: Matthias Kaehlcke <mka@...omium.org>
> 
> Should this have a "Fixes:" tag, and also be cc: stable@...r.kernel.org
> so that it will be properly backported?
> 
> If so, please add and resend.
> 

Okay, will add and resend.

> thanks,
> 
> greg k-h