linux-kernel - Re: [PATCH] treewide: remove editor modelines and cruft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72kb6sVQXVx6a5NwjFfrfJVZ35KVpj0xV8E7DU1SRV3AuA@mail.gmail.com>
Date:   Wed, 24 Mar 2021 11:59:47 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] treewide: remove editor modelines and cruft

Hi Masahiro,

On Wed, Mar 24, 2021 at 10:57 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> The section "19) Editor modelines and other cruft" in
> Documentation/process/coding-style.rst clearly says,
> "Do not include any of these in source files."
>
> I recently receive a patch to explicitly add a new one.
>
> Let's do treewide cleanups, otherwise some people follow the existing
> code and attempt to upstream their favoriate editor setups.
>
> It is even nicer if scripts/checkpatch.pl can check it.
>
> If we like to impose coding style in an editor-independent manner,
> I think editorconfig (patch [1]) is a saner solution.
>
> [1] https://lore.kernel.org/lkml/20200703073143.423557-1-danny@kdrag0n.dev/
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

+1 It is great to get rid of those.

For auxdisplay:

    Reviewed-by: Miguel Ojeda <ojeda@...nel.org>

For the rest, I did a quick visual inspection and didn't see anything wrong.

Cheers,
Miguel