linux-kernel - Re: [PATCH] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b6d57fb-8596-fa22-0a5a-9d535803d10a@nvidia.com>
Date:   Wed, 24 Mar 2021 16:48:06 +0530
From:   Sameer Pujar <spujar@...dia.com>
To:     Rob Herring <robh@...nel.org>, Mark Brown <broonie@...nel.org>
CC:     <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        <alsa-devel@...a-project.org>, <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing
 child nodes



On 3/24/2021 1:30 AM, Rob Herring wrote:
> External email: Use caution opening links or attachments
>
>
> The nvidia,tegra210-ahub binding is missing schema for child nodes. This
> results in warnings if 'additionalProperties: false' is set (or when the
> tools implement 'unevaluatedProperties' support). Add the child nodes
> and reference their schema if one exists.
>
> Cc: Liam Girdwood <lgirdwood@...il.com>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Jonathan Hunter <jonathanh@...dia.com>
> Cc: Sameer Pujar <spujar@...dia.com>
> Cc: alsa-devel@...a-project.org
> Cc: linux-tegra@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> This patch ideally should be applied before this series[1].
>
> [1] https://lore.kernel.org/r/20210323163634.877511-1-robh@kernel.org/
>
>   .../bindings/sound/nvidia,tegra210-ahub.yaml         | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> index e568d6c7dddd..d7a5eb77ed4f 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> @@ -69,6 +69,18 @@ properties:
>           $ref: audio-graph-port.yaml#
>           unevaluatedProperties: false
>
> +patternProperties:
> +  '^i2s@[0-9a-f]+$':
> +    type: object
> +
> +  '^dmic@[0-9a-f]+$':
> +    type: object
> +    $ref: nvidia,tegra210-dmic.yaml#
> +
> +  '^admaif@[0-9a-f]+$':
> +    type: object
> +    $ref: nvidia,tegra210-admaif.yaml#
> +

There is "dspk@xxx" child node as well for ahub, though schema example 
does not show this. I am seeing error because of this during 
"dtbs_check". Wondering if we can add following with this patch?

+  '^dspk@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra186-dspk.yaml#


>   required:
>     - compatible
>     - reg
> --
> 2.27.0
>