linux-kernel - Re: [PATCH v2 2/3] dt-bindings: Convert the rockchip power_domain to YAML and extend【请注意，邮件由robherring2@...il.com代发】

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Mar 2021 10:12:49 +0800
From:   "elaine.zhang" <zhangqing@...k-chips.com>
To:     Rob Herring <robh@...nel.org>
Cc:     tony.xie@...k-chips.com, huangtao@...k-chips.com, heiko@...ech.de,
        linux-kernel@...r.kernel.org, finley.xiao@...k-chips.com,
        kever.yang@...k-chips.com, linux-rockchip@...ts.infradead.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org, cl@...k-chips.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/3] dt-bindings: Convert the rockchip power_domain to YAML and extend【请注意，邮件由robherring2@...il.com代发】

Hi, Rob Herring

在 2021/3/24 上午4:16, Rob Herring 写道:
> On Tue, 23 Mar 2021 16:24:09 +0800, Elaine Zhang wrote:
>> This converts the rockchip power domain family bindings to YAML schema,
>> and add binding documentation for the power domains found on Rockchip
>> RK3568 SoCs.
>>
>> Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>
>> ---
>>   .../bindings/soc/rockchip/power_domain.txt    | 136 ---------
>>   .../rockchip/rockchip,power-controller.yaml   | 259 ++++++++++++++++++
>>   2 files changed, 259 insertions(+), 136 deletions(-)
>>   delete mode 100644 Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
>>   create mode 100644 Documentation/devicetree/bindings/soc/rockchip/rockchip,power-controller.yaml
>>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/soc/rockchip/rockchip,power-controller.example.dts:19:18: fatal error: dt-bindings/clock/rk3568-cru.h: No such file or directory
>     19 |         #include <dt-bindings/clock/rk3568-cru.h>
>        |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[1]: *** [scripts/Makefile.lib:349: Documentation/devicetree/bindings/soc/rockchip/rockchip,power-controller.example.dt.yaml] Error 1
> make: *** [Makefile:1380: dt_binding_check] Error 2

#include <dt-bindings/clock/rk3568-cru.h>
This file has been merged, can be seen on the Master branch of Linux-Next.
I will rearrange the submission based on this:
https://patchwork.kernel.org/project/linux-rockchip/patch/20210225102643.653095-1-enric.balletbo@collabora.com/

>
> See https://patchwork.ozlabs.org/patch/1457096
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
>
>