linux-kernel - RE: [PATCH v3] phy: zynqmp: Handle the clock enable/disable properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR02MB589819D4999945A32391A892C1639@DM6PR02MB5898.namprd02.prod.outlook.com>
Date:   Wed, 24 Mar 2021 12:21:12 +0000
From:   Manish Narani <MNARANI@...inx.com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:     "kishon@...com" <kishon@...com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        Michal Simek <michals@...inx.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>, git <git@...inx.com>
Subject: RE: [PATCH v3] phy: zynqmp: Handle the clock enable/disable properly

Hi Laurent,

Thank you so much for the review.

> -----Original Message-----
> From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Sent: Wednesday, March 24, 2021 8:38 AM
> To: Manish Narani <MNARANI@...inx.com>
> Cc: kishon@...com; vkoul@...nel.org; Michal Simek <michals@...inx.com>;
> linux-kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; git
> <git@...inx.com>
> Subject: Re: [PATCH v3] phy: zynqmp: Handle the clock enable/disable
> properly
> 
> Hi Manish,
> 
> Thank you for the patch.
> 
> On Tue, Mar 23, 2021 at 07:49:47PM +0530, Manish Narani wrote:
> > The current driver is not handling the clock enable/disable operations
> > properly. The clocks need to be handled correctly by enabling or
> > disabling at appropriate places. This patch adds code to handle the
> > same.
> >
> > Signed-off-by: Manish Narani <manish.narani@...inx.com>
> 
> This looks good to me.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> However, it would be really nice to make clock handling dynamic, to only
> enable clocks that are needed by active PHYs. Keeping them enabled at
> all times will waste power. It can be done on top of this patch. Is it
> something you could work on ?

Sure. I'll plan to work on that.

I have sent v4 for this with Michal's input.

Thanks,
Manish