linux-kernel - Re: turbostat: Fix Pkg Power on Zen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFsyh5tEaiVNjqT1@lorien.valinor.li>
Date:   Wed, 24 Mar 2021 13:37:27 +0100
From:   Salvatore Bonaccorso <carnil@...ian.org>
To:     Len Brown <len.brown@...el.com>
Cc:     Christian Kastner <ckk@...ian.org>, Kurt Garloff <kurt@...loff.de>,
        LKML <linux-kernel@...r.kernel.org>, linux-pm@...r.kernel.org
Subject: Re: turbostat: Fix Pkg Power on Zen

Hi Len,

On Mon, Mar 15, 2021 at 10:54:24PM +0100, Christian Kastner wrote:
> Hi,
> 
> On 01.02.21 10:01, Kurt Garloff wrote:
> > Issue persists on Ryzen in 5.11-rc6:
> > 
> > kvmadmin@...tSrv2018(//):~ [0]$ sudo /casa/src/linux-stable/tools/power/x86/turbostat/turbostat
> > [...]
> > kvmadmin@...tSrv2018(//):~ [243]$
> > 
> > ?????????????????????????????????????????????????????? ^^^ Exit code
> > 
> > With the patch:
> > 
> > kvmadmin@...tSrv2018(//):~ [243]$ sudo /casa/src/linux-stable/tools/power/x86/turbostat/turbostat??????
> > [...]???????????????????????????????????? 
> > Core?????? CPU???????? Avg_MHz Busy%???? Bzy_MHz TSC_MHz IRQ???????? POLL?????? C1?????????? C2?????????? POLL%???? C1%???????? C2%???????? CorWatt PkgWatt
> > -???????????? -???????????? 27?????????? 1.04?????? 2562?????? 3411?????? 16046???? 33?????????? 2931?????? 12895???? 0.00?????? 0.85?????? 98.48???? 1.57?????? 18.81
> > 0???????????? 0???????????? 12?????????? 0.55?????? 2193?????? 3400?????? 885???????? 1???????????? 111???????? 757???????? 0.00?????? 1.12?????? 98.42???? 0.04?????? 18.74
> > 0???????????? 16?????????? 1???????????? 0.05?????? 2351?????? 3400?????? 53?????????? 0???????????? 3???????????? 54?????????? 0.00?????? 0.05?????? 99.92????????????
> > 1???????????? 1???????????? 20?????????? 0.89?????? 2261?????? 3400?????? 478???????? 0???????????? 39?????????? 427???????? 0.00?????? 0.37?????? 98.80???? 0.06
> > 1???????????? 17?????????? 9???????????? 0.40?????? 2329?????? 3400?????? 308???????? 0???????????? 38?????????? 282???????? 0.00?????? 0.35?????? 99.29????????????
> > [...]
> 
> I was seeing the same issue (no stats, program just exits with 243), and
> Kurt's simple patch resolved it for me.

Does Kurt's patch seems good to you and can be applied or is there
anything missing?

Regards,
Salvatore