linux-kernel - Re: [PATCH v1 1/1] dmaengine: dw: Make it dependent to HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210324135116.z3xjyjreni24roez@mobilestation>
Date:   Wed, 24 Mar 2021 16:51:16 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        Viresh Kumar <vireshk@...nel.org>,
        Vinod Koul <vkoul@...nel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v1 1/1] dmaengine: dw: Make it dependent to HAVE_IOMEM

Hi Andy

On Wed, Mar 24, 2021 at 02:18:22PM +0200, Andy Shevchenko wrote:
> Some architectures do not provide devm_*() APIs. Hence make the driver
> dependent on HAVE_IOMEM.

You must have meant "HAS_IOMEM", right?

-Sergey

> 
> Fixes: dbde5c2934d1 ("dw_dmac: use devm_* functions to simplify code")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/dma/dw/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig
> index e5162690de8f..dd4b56669d9f 100644
> --- a/drivers/dma/dw/Kconfig
> +++ b/drivers/dma/dw/Kconfig
> @@ -10,6 +10,7 @@ config DW_DMAC_CORE
>  
>  config DW_DMAC
>  	tristate "Synopsys DesignWare AHB DMA platform driver"
> +	depends on HAVE_IOMEM
>  	select DW_DMAC_CORE
>  	help
>  	  Support the Synopsys DesignWare AHB DMA controller. This
> @@ -18,6 +19,7 @@ config DW_DMAC
>  config DW_DMAC_PCI
>  	tristate "Synopsys DesignWare AHB DMA PCI driver"
>  	depends on PCI
> +	depends on HAVE_IOMEM
>  	select DW_DMAC_CORE
>  	help
>  	  Support the Synopsys DesignWare AHB DMA controller on the
> -- 
> 2.30.2
>