linux-kernel - Re: [PATCH] [v3] drivers: watchdog: Remove duplicate include of kernel.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48c7d893-532d-a62c-a300-09b3b9d6d746@roeck-us.net>
Date:   Thu, 25 Mar 2021 07:36:57 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Wan Jiabing <wanjiabing@...o.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kael_w@...h.net
Subject: Re: [PATCH] [v3] drivers: watchdog: Remove duplicate include of
 kernel.h

On 3/25/21 4:29 AM, Wan Jiabing wrote:
> linux/kernel.h has been included. Remove the duplicate.
> Reorder include files to be in alphabetic order.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> Changelog:
> v3:
> - Reorder include files to be in alphabetic order.
> 
> v2:
> - Remove the duplicate which won't make worse.
> ---
>  drivers/watchdog/dw_wdt.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e1781e63..cd578843277e 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -13,22 +13,21 @@
>   */
>  
>  #include <linux/bitops.h>
> -#include <linux/limits.h>
> -#include <linux/kernel.h>
>  #include <linux/clk.h>
> +#include <linux/debugfs.h>
>  #include <linux/delay.h>
>  #include <linux/err.h>
> +#include <linux/interrupt.h>
>  #include <linux/io.h>
>  #include <linux/kernel.h>
> +#include <linux/limits.h>
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
> -#include <linux/interrupt.h>
>  #include <linux/of.h>
> -#include <linux/pm.h>
>  #include <linux/platform_device.h>
> +#include <linux/pm.h>
>  #include <linux/reset.h>
>  #include <linux/watchdog.h>
> -#include <linux/debugfs.h>
>  
>  #define WDOG_CONTROL_REG_OFFSET		    0x00
>  #define WDOG_CONTROL_REG_WDT_EN_MASK	    0x01
>