linux-kernel - Re: ext2_set_link()->ext2_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210325145457.GE13673@quack2.suse.cz>
Date:   Thu, 25 Mar 2021 15:54:57 +0100
From:   Jan Kara <jack@...e.cz>
To:     Ira Weiny <ira.weiny@...el.com>
Cc:     Jan Kara <jack@...e.com>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: ext2_set_link()->ext2_put_page() question

On Mon 22-03-21 17:49:48, Ira Weiny wrote:
> Jan,
> 
> Why does ext2_set_link() need to call ext2_put_page()?
> 
> I don't see any reason that we could not match up the ext2_put_page() calls
> with the ext2_find_entry().
> 
> Similarly am I missing something by moving the ext2_put_page() out of
> ext2_delete_entry()?
> 
> See below patch.

I agree that your patch improves readability. But please fixup comments
about releasing a page as well. Thanks!

> I'm in the process of changing the kmap() calls in ext2_[get|put]_page() into
> kmap_local_page() and I noticed this imbalance.  It does not really save me
> anything because I need to pass the kaddr into these calls but IMO it makes the
> code a bit easier to follow.
> 
> If you agree I will get a patch together to submit with the kmap_local_page()
> patch.

OK :).

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR