linux-kernel - Re: [PATCH] [v2] include: linux: debug_locks: Remove duplicate declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YFywEil0TwbHItSJ@smile.fi.intel.com>
Date:   Thu, 25 Mar 2021 17:45:22 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        linux-kernel@...r.kernel.org, keal_w@...h.net
Subject: Re: [PATCH] [v2] include: linux: debug_locks: Remove duplicate
 declaration

On Thu, Mar 25, 2021 at 11:20:28PM +0800, Wan Jiabing wrote:
> struct task_struct has been declared.

"...declared twice."

In the subject line the "include: linux: " part is not needed.

FWIW, after addressing above,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Remove the duplicate.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
> Changelog:
> v2:
> - Remove another duplicate declaration for being closer
>   to its user.
> ---
>  include/linux/debug_locks.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
> index 2915f56ad421..32f6a37a3d3f 100644
> --- a/include/linux/debug_locks.h
> +++ b/include/linux/debug_locks.h
> @@ -6,8 +6,6 @@
>  #include <linux/bug.h>
>  #include <linux/printk.h>
>  
> -struct task_struct;
> -
>  extern int debug_locks __read_mostly;
>  extern int debug_locks_silent __read_mostly;
>  
> -- 
> 2.25.1
> 

-- 
With Best Regards,
Andy Shevchenko