linux-kernel - Re: [PATCH v2] kbuild: enforce -Werror=unused-result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNARPs97+eQKMop9cYCs=D4Kwsf_5pq-614OUxT2iZptueg@mail.gmail.com>
Date:   Fri, 26 Mar 2021 01:55:41 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Olaf Hering <olaf@...fle.de>
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] kbuild: enforce -Werror=unused-result

On Thu, Mar 25, 2021 at 8:16 PM Olaf Hering <olaf@...fle.de> wrote:
>
> Am Fri, 19 Mar 2021 15:32:31 +0100
> schrieb Olaf Hering <olaf@...fle.de>:
>
> > It is a hard error if a return value is ignored.
>
> The automated builds found only a single error, in load_em86().

What about  drivers/net/ethernet/lantiq_etop.c  ?

> Let me know if there are other reasons why the patch was rejected.
>
> Olaf

I got a lot of complaints in the last trial.

It is easy to send a patch like this, but difficult to
make sure that I will not break any CI tests.

Over time, I started to believe keeping this as a warning
is OK.

The same problem happens when you add a new __must_check
annotation. You end up with fixing all the call-sites in advance.

-- 
Best Regards
Masahiro Yamada