linux-kernel - Re: [PATCH 2/2] media: videobuf2: cleanup size argument from attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Mar 2021 11:44:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Helen Koike <helen.koike@...labora.com>,
        linux-media@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        hverkuil@...all.nl, kernel@...labora.com,
        linux-kernel@...r.kernel.org, jc@...esim.co.uk,
        laurent.pinchart@...asonboard.com, dave.stevenson@...pberrypi.org,
        tfiga@...omium.org, Helen Koike <helen.koike@...labora.com>
Subject: Re: [PATCH 2/2] media: videobuf2: cleanup size argument from
 attach_dmabuf()

Hi Helen,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on next-20210324]
[cannot apply to v5.12-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Helen-Koike/media-videobuf2-use-dmabuf-size-for-length/20210325-082047
base:   git://linuxtv.org/media_tree.git master
config: powerpc64-randconfig-r016-20210325 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 5d6b4aa80d6df62b924a12af030c5ded868ee4f1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://github.com/0day-ci/linux/commit/41e2cea31db8378b33e31785aec668a009d1355b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Helen-Koike/media-videobuf2-use-dmabuf-size-for-length/20210325-082047
        git checkout 41e2cea31db8378b33e31785aec668a009d1355b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/media/common/videobuf2/videobuf2-dma-sg.c:631:14: error: use of undeclared identifier 'dmabuf'; did you mean 'dbuf'?
           buf->size = dmabuf->size;
                       ^~~~~~
                       dbuf
   drivers/media/common/videobuf2/videobuf2-dma-sg.c:608:75: note: 'dbuf' declared here
   static void *vb2_dma_sg_attach_dmabuf(struct device *dev, struct dma_buf *dbuf,
                                                                             ^
   1 error generated.


vim +631 drivers/media/common/videobuf2/videobuf2-dma-sg.c

   607	
   608	static void *vb2_dma_sg_attach_dmabuf(struct device *dev, struct dma_buf *dbuf,
   609					      enum dma_data_direction dma_dir)
   610	{
   611		struct vb2_dma_sg_buf *buf;
   612		struct dma_buf_attachment *dba;
   613	
   614		if (WARN_ON(!dev))
   615			return ERR_PTR(-EINVAL);
   616	
   617		buf = kzalloc(sizeof(*buf), GFP_KERNEL);
   618		if (!buf)
   619			return ERR_PTR(-ENOMEM);
   620	
   621		buf->dev = dev;
   622		/* create attachment for the dmabuf with the user device */
   623		dba = dma_buf_attach(dbuf, buf->dev);
   624		if (IS_ERR(dba)) {
   625			pr_err("failed to attach dmabuf\n");
   626			kfree(buf);
   627			return dba;
   628		}
   629	
   630		buf->dma_dir = dma_dir;
 > 631		buf->size = dmabuf->size;
   632		buf->db_attach = dba;
   633	
   634		return buf;
   635	}
   636	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (40444 bytes)