linux-kernel - Re: [PATCH v2] kbuild: enforce -Werror=unused-result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATaDL0h6wA16jNBCg=zg8XL2zSSPLyvq6mriLDTjO0LMQ@mail.gmail.com>
Date:   Fri, 26 Mar 2021 02:32:49 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Olaf Hering <olaf@...fle.de>
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] kbuild: enforce -Werror=unused-result

On Fri, Mar 26, 2021 at 2:07 AM Olaf Hering <olaf@...fle.de> wrote:
>
> Am Fri, 26 Mar 2021 01:55:41 +0900
> schrieb Masahiro Yamada <masahiroy@...nel.org>:
>
> > What about  drivers/net/ethernet/lantiq_etop.c  ?
>
> Nothing complained about it. I guess there is a build-bot for alpha, but none for mips.
>
> > I got a lot of complaints in the last trial.
>
> Why did you get complains, instead of me?
>
>
> What is the "must" in "__must_check" worth if it is not enforced...
>
> Olaf


In hindsight, __must_check may not be a perfect name.

Miguel suggested __nodiscard to get along with:
https://en.cppreference.com/w/c/language/attributes/nodiscard

It is not enforcing. Just a compiler warning.


-- 
Best Regards
Masahiro Yamada